Alistair Leslie-Hughes : mshtml: Implement IHTMLStyle get/put wordSpacing.

Alexandre Julliard julliard at winehq.org
Fri Aug 21 09:33:03 CDT 2009


Module: wine
Branch: master
Commit: 4975243db388e282e91553cb95dca3e8739b582b
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=4975243db388e282e91553cb95dca3e8739b582b

Author: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
Date:   Fri Aug 21 20:55:29 2009 +1000

mshtml: Implement IHTMLStyle get/put wordSpacing.

---

 dlls/mshtml/htmlstyle.c |   11 +++++++----
 dlls/mshtml/htmlstyle.h |    1 +
 dlls/mshtml/tests/dom.c |   20 ++++++++++++++++++++
 3 files changed, 28 insertions(+), 4 deletions(-)

diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c
index f938005..a5e0ace 100644
--- a/dlls/mshtml/htmlstyle.c
+++ b/dlls/mshtml/htmlstyle.c
@@ -121,6 +121,8 @@ static const WCHAR attrVisibility[] =
     {'v','i','s','i','b','i','l','i','t','y',0};
 static const WCHAR attrWidth[] =
     {'w','i','d','t','h',0};
+static const WCHAR attrWordSpacing[] =
+    {'w','o','r','d','-','s','p','a','c','i','n','g',0};
 static const WCHAR attrWordWrap[] =
     {'w','o','r','d','-','w','r','a','p',0};
 static const WCHAR attrZIndex[] =
@@ -173,6 +175,7 @@ static const struct{
     {attrVerticalAlign,        DISPID_IHTMLSTYLE_VERTICALALIGN},
     {attrVisibility,           DISPID_IHTMLSTYLE_VISIBILITY},
     {attrWidth,                DISPID_IHTMLSTYLE_WIDTH},
+    {attrWordSpacing,          DISPID_IHTMLSTYLE_WORDSPACING},
     {attrWordWrap,             DISPID_IHTMLSTYLE3_WORDWRAP},
     {attrZIndex,               DISPID_IHTMLSTYLE_ZINDEX}
 };
@@ -923,15 +926,15 @@ static HRESULT WINAPI HTMLStyle_get_backgroundPositionY(IHTMLStyle *iface, VARIA
 static HRESULT WINAPI HTMLStyle_put_wordSpacing(IHTMLStyle *iface, VARIANT v)
 {
     HTMLStyle *This = HTMLSTYLE_THIS(iface);
-    FIXME("(%p)->(v%d)\n", This, V_VT(&v));
-    return E_NOTIMPL;
+    TRACE("(%p)->(v%d)\n", This, V_VT(&v));
+    return set_nsstyle_attr_var(This->nsstyle, STYLEID_WORD_SPACING, &v, 0);
 }
 
 static HRESULT WINAPI HTMLStyle_get_wordSpacing(IHTMLStyle *iface, VARIANT *p)
 {
     HTMLStyle *This = HTMLSTYLE_THIS(iface);
-    FIXME("(%p)->(%p)\n", This, p);
-    return E_NOTIMPL;
+    TRACE("(%p)->(%p)\n", This, p);
+    return get_nsstyle_attr_var(This->nsstyle, STYLEID_WORD_SPACING, p, 0);
 }
 
 static HRESULT WINAPI HTMLStyle_put_letterSpacing(IHTMLStyle *iface, VARIANT v)
diff --git a/dlls/mshtml/htmlstyle.h b/dlls/mshtml/htmlstyle.h
index beab44e..41581f3 100644
--- a/dlls/mshtml/htmlstyle.h
+++ b/dlls/mshtml/htmlstyle.h
@@ -78,6 +78,7 @@ typedef enum {
     STYLEID_VERTICAL_ALIGN,
     STYLEID_VISIBILITY,
     STYLEID_WIDTH,
+    STYLEID_WORD_SPACING,
     STYLEID_WORD_WRAP,
     STYLEID_Z_INDEX
 } styleid_t;
diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c
index 5cec17e..dd2c63a 100644
--- a/dlls/mshtml/tests/dom.c
+++ b/dlls/mshtml/tests/dom.c
@@ -3689,6 +3689,26 @@ static void test_default_style(IHTMLStyle *style)
     ok(hres == S_OK, "put_borderLeftWidth: %08x\n", hres);
     VariantClear(&vDefault);
 
+    /* wordSpacing */
+    hres = IHTMLStyle_get_wordSpacing(style, &vDefault);
+    ok(hres == S_OK, "get_wordSpacing: %08x\n", hres);
+
+    V_VT(&v) = VT_BSTR;
+    V_BSTR(&v) = a2bstr("10");
+    hres = IHTMLStyle_put_wordSpacing(style, v);
+    ok(hres == S_OK, "put_wordSpacing: %08x\n", hres);
+    VariantClear(&v);
+
+    hres = IHTMLStyle_get_wordSpacing(style, &v);
+    ok(hres == S_OK, "get_wordSpacing: %08x\n", hres);
+    ok(V_VT(&v) == VT_BSTR, "V_VT(v)=%d\n", V_VT(&v));
+    ok(!strcmp_wa(V_BSTR(&v), "10px"), "expected 10px = %s\n", wine_dbgstr_w(V_BSTR(&v)));
+    VariantClear(&v);
+
+    hres = IHTMLStyle_put_wordSpacing(style, vDefault);
+    ok(hres == S_OK, "put_wordSpacing: %08x\n", hres);
+    VariantClear(&vDefault);
+
     hres = IHTMLStyle_QueryInterface(style, &IID_IHTMLStyle2, (void**)&style2);
     ok(hres == S_OK, "Could not get IHTMLStyle2 iface: %08x\n", hres);
     if(SUCCEEDED(hres)) {




More information about the wine-cvs mailing list