Marcus Meissner : winspool.drv: Check ptr for being NULL (Coverity).

Alexandre Julliard julliard at winehq.org
Thu Dec 3 10:29:53 CST 2009


Module: wine
Branch: master
Commit: faf1485e4e0744af0bc6119f0d680a8ab025b08e
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=faf1485e4e0744af0bc6119f0d680a8ab025b08e

Author: Marcus Meissner <marcus at jet.franken.de>
Date:   Thu Dec  3 10:18:19 2009 +0100

winspool.drv: Check ptr for being NULL (Coverity).

---

 dlls/winspool.drv/info.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/winspool.drv/info.c b/dlls/winspool.drv/info.c
index ad99988..8e4d714 100644
--- a/dlls/winspool.drv/info.c
+++ b/dlls/winspool.drv/info.c
@@ -3337,7 +3337,7 @@ static BOOL WINSPOOL_GetDevModeFromReg(HKEY hkey, LPCWSTR ValueName,
     if (ptr && ((DEVMODEA*)ptr)->dmSize < sizeof(DEVMODEA))
         ((DEVMODEA*)ptr)->dmSize = sizeof(DEVMODEA);
     sz += (CCHDEVICENAME + CCHFORMNAME);
-    if(buflen >= sz) {
+    if (ptr && (buflen >= sz)) {
         DEVMODEW *dmW = GdiConvertToDevmodeW((DEVMODEA*)ptr);
         memcpy(ptr, dmW, sz);
         HeapFree(GetProcessHeap(),0,dmW);




More information about the wine-cvs mailing list