Hans Leidekker : msi: Avoid a crash in STREAMS_delete.

Alexandre Julliard julliard at winehq.org
Fri Dec 18 10:49:09 CST 2009


Module: wine
Branch: master
Commit: 699cfc915abf823ba916b39a2cbd2eba3890f17f
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=699cfc915abf823ba916b39a2cbd2eba3890f17f

Author: Hans Leidekker <hans at codeweavers.com>
Date:   Fri Dec 18 11:02:30 2009 +0100

msi: Avoid a crash in STREAMS_delete.

---

 dlls/msi/streams.c |   12 ++++++++----
 1 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/dlls/msi/streams.c b/dlls/msi/streams.c
index 6b281f4..4825ae6 100644
--- a/dlls/msi/streams.c
+++ b/dlls/msi/streams.c
@@ -400,10 +400,14 @@ static UINT STREAMS_delete(struct tagMSIVIEW *view)
 
     for (i = 0; i < sv->num_rows; i++)
     {
-        if (sv->streams[i] && sv->streams[i]->stream)
-            IStream_Release(sv->streams[i]->stream);
-        msi_free(sv->streams[i]->name);
-        msi_free(sv->streams[i]);
+        if (sv->streams[i])
+        {
+            if (sv->streams[i]->stream)
+                IStream_Release(sv->streams[i]->stream);
+
+            msi_free(sv->streams[i]->name);
+            msi_free(sv->streams[i]);
+        }
     }
 
     msi_free(sv->streams);




More information about the wine-cvs mailing list