Hans Leidekker : secur32/tests: Fix a couple of memory leaks.

Alexandre Julliard julliard at winehq.org
Mon Dec 21 09:39:47 CST 2009


Module: wine
Branch: master
Commit: 44f9595454e022c82bc5e467b1cd952a2a4d2b73
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=44f9595454e022c82bc5e467b1cd952a2a4d2b73

Author: Hans Leidekker <hans at codeweavers.com>
Date:   Sat Dec 19 22:29:52 2009 +0100

secur32/tests: Fix a couple of memory leaks.

Found by Valgrind.

---

 dlls/secur32/tests/ntlm.c |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/dlls/secur32/tests/ntlm.c b/dlls/secur32/tests/ntlm.c
index db00d73..d9f9538 100644
--- a/dlls/secur32/tests/ntlm.c
+++ b/dlls/secur32/tests/ntlm.c
@@ -775,6 +775,8 @@ static void testInitializeSecurityContextFlags(void)
 tISCFend:
     cleanupBuffers(&client);
     pFreeCredentialsHandle(client.cred);
+    HeapFree(GetProcessHeap(), 0, client.cred);
+    HeapFree(GetProcessHeap(), 0, client.ctxt);
 
 }
 
@@ -911,6 +913,11 @@ tAuthend:
     sec_status = pFreeCredentialsHandle(client.cred);
     ok(sec_status == SEC_E_OK, "FreeCredentialsHandle(client) returned %s\n",
             getSecError(sec_status));
+
+    HeapFree(GetProcessHeap(), 0, client.cred);
+    HeapFree(GetProcessHeap(), 0, client.ctxt);
+    HeapFree(GetProcessHeap(), 0, server.cred);
+    HeapFree(GetProcessHeap(), 0, server.ctxt);
 }
 
 static void testSignSeal(void)
@@ -1186,6 +1193,8 @@ end:
     HeapFree(GetProcessHeap(), 0, data[1].pvBuffer);
     HeapFree(GetProcessHeap(), 0, complex_data[1].pvBuffer);
     HeapFree(GetProcessHeap(), 0, complex_data[3].pvBuffer);
+    HeapFree(GetProcessHeap(), 0, server.cred);
+    HeapFree(GetProcessHeap(), 0, server.ctxt);
 }
 
 static void testAcquireCredentialsHandle(void)
@@ -1317,6 +1326,8 @@ static void test_cred_multiple_use(void)
     ok(ret == SEC_E_OK, "DeleteSecurityContext failed with error 0x%x\n", ret);
     ret = pFreeCredentialsHandle(&cred);
     ok(ret == SEC_E_OK, "FreeCredentialsHandle failed with error 0x%x\n", ret);
+
+    HeapFree(GetProcessHeap(), 0, buffers[0].pvBuffer);
 }
 
 static void test_null_auth_data(void)
@@ -1358,6 +1369,8 @@ static void test_null_auth_data(void)
                                          ISC_REQ_CONNECTION, 0, SECURITY_NETWORK_DREP,
                                          NULL, 0, &ctx, &buffer_desc, &attr, &ttl);
     ok(status == SEC_I_CONTINUE_NEEDED, "InitializeSecurityContextA failed %s\n", getSecError(status));
+
+    HeapFree(GetProcessHeap(), 0, buffers[0].pvBuffer);
 }
 
 START_TEST(ntlm)




More information about the wine-cvs mailing list