Marcus Meissner : services: Handle realloc failures better (Coverity).

Alexandre Julliard julliard at winehq.org
Mon Feb 2 09:01:18 CST 2009


Module: wine
Branch: master
Commit: 2c7ac13662915858046f2f94fe9fcb9d52c6ff96
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=2c7ac13662915858046f2f94fe9fcb9d52c6ff96

Author: Marcus Meissner <marcus at jet.franken.de>
Date:   Sat Jan 31 11:44:12 2009 +0100

services: Handle realloc failures better (Coverity).

---

 programs/services/services.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/programs/services/services.c b/programs/services/services.c
index 003771f..9bed784 100644
--- a/programs/services/services.c
+++ b/programs/services/services.c
@@ -242,10 +242,12 @@ static void scmdatabase_autostart_services(struct scmdatabase *db)
         {
             if (i+1 >= size)
             {
+                struct service_entry **slist_new;
                 size *= 2;
-                services_list = HeapReAlloc(GetProcessHeap(), 0, services_list, size * sizeof(services_list[0]));
-                if (!services_list)
+                slist_new = HeapReAlloc(GetProcessHeap(), 0, services_list, size * sizeof(services_list[0]));
+                if (!slist_new)
                     break;
+                services_list = slist_new;
             }
             services_list[i] = service;
             service->ref_count++;




More information about the wine-cvs mailing list