Rob Shearman : rpcrt4: Fix use of uninitialised variable in NdrDllRegisterProxy.

Alexandre Julliard julliard at winehq.org
Tue Feb 24 10:21:56 CST 2009


Module: wine
Branch: master
Commit: 86f79e3a558ca1fb5d596e9f62403ca89178d3cf
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=86f79e3a558ca1fb5d596e9f62403ca89178d3cf

Author: Rob Shearman <robertshearman at gmail.com>
Date:   Tue Feb 24 14:53:17 2009 +0000

rpcrt4: Fix use of uninitialised variable in NdrDllRegisterProxy.

It should be key, not subkey being passed into RegSetValueExW.

---

 dlls/rpcrt4/cpsf.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/rpcrt4/cpsf.c b/dlls/rpcrt4/cpsf.c
index bece899..a0d541d 100644
--- a/dlls/rpcrt4/cpsf.c
+++ b/dlls/rpcrt4/cpsf.c
@@ -266,7 +266,7 @@ HRESULT WINAPI NdrDllRegisterProxy(HMODULE hDll,
   if (len && len < sizeof(module)) {
       TRACE("registering CLSID %s => %s\n", debugstr_w(clsid), debugstr_w(module));
       if (RegCreateKeyW(HKEY_CLASSES_ROOT, keyname, &key) == ERROR_SUCCESS) {
-          RegSetValueExW(subkey, NULL, 0, REG_SZ, (const BYTE *)psfactoryW, sizeof(psfactoryW));
+          RegSetValueExW(key, NULL, 0, REG_SZ, (const BYTE *)psfactoryW, sizeof(psfactoryW));
           if (RegCreateKeyW(key, inprocserverW, &subkey) == ERROR_SUCCESS) {
               RegSetValueExW(subkey, NULL, 0, REG_SZ, (LPBYTE)module, (strlenW(module)+1)*sizeof(WCHAR));
               RegSetValueExW(subkey, threadingmodelW, 0, REG_SZ, (const BYTE *)bothW, sizeof(bothW));




More information about the wine-cvs mailing list