Mikołaj Zalewski : regedit: Don' t pass an ANSI string to vsprintfW.

Alexandre Julliard julliard at winehq.org
Wed Jan 21 06:40:20 CST 2009


Module: wine
Branch: master
Commit: f2235ef30d7084a1a7d9faadcd5ce96124045b6a
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=f2235ef30d7084a1a7d9faadcd5ce96124045b6a

Author: Mikołaj Zalewski <mikolaj at zalewski.pl>
Date:   Tue Jan 20 22:45:41 2009 +0100

regedit: Don't pass an ANSI string to vsprintfW.

---

 programs/regedit/edit.c |    9 ++-------
 1 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/programs/regedit/edit.c b/programs/regedit/edit.c
index 2c5b23d..d9f4005 100644
--- a/programs/regedit/edit.c
+++ b/programs/regedit/edit.c
@@ -436,13 +436,8 @@ BOOL DeleteValue(HWND hwnd, HKEY hKeyRoot, LPCWSTR keyPath, LPCWSTR valueName, B
 
     if (showMessageBox)
     {
-        LPSTR visibleValueNameA = GetMultiByteString(visibleValueName);
-        if (messagebox(hwnd, MB_YESNO | MB_ICONEXCLAMATION, IDS_DELETE_BOX_TITLE, IDS_DELETE_BOX_TEXT, visibleValueNameA) != IDYES)
-        {
-                HeapFree(GetProcessHeap(), 0, visibleValueNameA);
-	        goto done;
-        }
-        HeapFree(GetProcessHeap(), 0, visibleValueNameA);
+        if (messagebox(hwnd, MB_YESNO | MB_ICONEXCLAMATION, IDS_DELETE_BOX_TITLE, IDS_DELETE_BOX_TEXT, visibleValueName) != IDYES)
+            goto done;
     }
 
     lRet = RegDeleteValueW(hKey, valueName ? valueName : &empty);




More information about the wine-cvs mailing list