Marcus Meissner : msxml3: Handle get_element returning NULL (Coverity).
Alexandre Julliard
julliard at winehq.org
Thu Jan 29 09:15:19 CST 2009
Module: wine
Branch: master
Commit: 525a5510d15952cb388cd124ca8d226aeaa081d6
URL: http://source.winehq.org/git/wine.git/?a=commit;h=525a5510d15952cb388cd124ca8d226aeaa081d6
Author: Marcus Meissner <marcus at jet.franken.de>
Date: Wed Jan 28 23:25:16 2009 +0100
msxml3: Handle get_element returning NULL (Coverity).
---
dlls/msxml3/element.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/dlls/msxml3/element.c b/dlls/msxml3/element.c
index f479395..4f0bce9 100644
--- a/dlls/msxml3/element.c
+++ b/dlls/msxml3/element.c
@@ -644,6 +644,7 @@ static HRESULT WINAPI domelem_getElementsByTagName(
{
domelem *This = impl_from_IXMLDOMElement( iface );
LPWSTR szPattern;
+ xmlNodePtr element;
HRESULT hr;
TRACE("(%p)->(%s,%p)\n", This, debugstr_w(bstrName), resultList);
@@ -654,7 +655,11 @@ static HRESULT WINAPI domelem_getElementsByTagName(
lstrcpyW(szPattern+3, bstrName);
TRACE("%s\n", debugstr_w(szPattern));
- hr = queryresult_create(get_element(This), szPattern, resultList);
+ element = get_element(This);
+ if (!element)
+ hr = E_FAIL;
+ else
+ hr = queryresult_create(element, szPattern, resultList);
HeapFree(GetProcessHeap(), 0, szPattern);
return hr;
More information about the wine-cvs
mailing list