Alexander Nicolaysen Sørnes : note: Fix a warning when editing notes

Alexander Nicolaysen Sørnes asornes at winehq.org
Wed Jul 29 09:33:11 CDT 2009


Module: appdb
Branch: master
Commit: c3beccd38dcb2c13b27ebb4166a4c03a8b4f11c3
URL:    http://source.winehq.org/git/appdb.git/?a=commit;h=c3beccd38dcb2c13b27ebb4166a4c03a8b4f11c3

Author: Alexander Nicolaysen Sørnes <alex at thehandofagony.com>
Date:   Wed Jul 29 16:32:37 2009 +0200

note: Fix a warning when editing notes

---

 include/note.php |   17 ++++++++++-------
 1 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/include/note.php b/include/note.php
index fec4edf..9b0e8fb 100644
--- a/include/note.php
+++ b/include/note.php
@@ -333,11 +333,17 @@ class Note {
 
     function outputEditor($aValues = null)
     {
-        if(!$this->iVersionId)
-            $this->iVersionId = getInput('iVersionId', $aValues);
+        if($aValues)
+        {
+            if(!$this->iVersionId)
+                $this->iVersionId = getInput('iVersionId', $aValues);
 
-        if(!$this->iAppId)
-            $this->iAppId = getInput('iAppId', $aValues);
+            if(!$this->iAppId)
+                $this->iAppId = getInput('iAppId', $aValues);
+
+            if(!$this->sTitle)
+                $this->sTitle = getInput('sNoteTitle', $aValues);
+        }
 
         if($this->iAppId && !$this->iVersionId)
             $this->iVersionId = APPNOTE_SHOW_FOR_ALL;
@@ -348,9 +354,6 @@ class Note {
             $this->iAppId = $oVersion->iAppId;
         }
 
-        if(!$this->sTitle)
-            $this->sTitle = getInput('sNoteTitle', $aValues);
-
         HtmlAreaLoaderScript(array("editor"));
 
         echo html_frame_start("Edit Application Note {$aClean['noteId']}", "90%","",0);




More information about the wine-cvs mailing list