Yuriy Kaminskiy : dsound: Fix segv on use-after-free in IDirectSoundNotifyImpl_Release.

Alexandre Julliard julliard at winehq.org
Mon Jun 1 10:01:00 CDT 2009


Module: wine
Branch: master
Commit: cb93f15e32230d29637492be78d410d46e73d7ad
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=cb93f15e32230d29637492be78d410d46e73d7ad

Author: Yuriy Kaminskiy <yumkam at mail.ru>
Date:   Sat May 30 20:59:13 2009 +0400

dsound: Fix segv on use-after-free in IDirectSoundNotifyImpl_Release.

---

 dlls/dsound/buffer.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/dsound/buffer.c b/dlls/dsound/buffer.c
index 251c436..2d64341 100644
--- a/dlls/dsound/buffer.c
+++ b/dlls/dsound/buffer.c
@@ -82,8 +82,8 @@ static ULONG WINAPI IDirectSoundNotifyImpl_Release(LPDIRECTSOUNDNOTIFY iface)
     TRACE("(%p) ref was %d\n", This, ref + 1);
 
     if (!ref) {
-        IDirectSoundBuffer_Release((LPDIRECTSOUNDBUFFER)This->dsb);
         This->dsb->notify = NULL;
+        IDirectSoundBuffer_Release((LPDIRECTSOUNDBUFFER)This->dsb);
         HeapFree(GetProcessHeap(), 0, This);
         TRACE("(%p) released\n", This);
     }




More information about the wine-cvs mailing list