James Hawkins : kernel32: Set last error to ERROR_FILE_NOT_FOUND if lpAppName is NULL.

Alexandre Julliard julliard at winehq.org
Tue Mar 24 09:01:56 CDT 2009


Module: wine
Branch: master
Commit: f1308f9b40d65e795e8d15f14fd8be7defcb4ed0
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=f1308f9b40d65e795e8d15f14fd8be7defcb4ed0

Author: James Hawkins <truiken at gmail.com>
Date:   Sun Mar 22 14:37:31 2009 -0700

kernel32: Set last error to ERROR_FILE_NOT_FOUND if lpAppName is NULL.

---

 dlls/kernel32/profile.c       |    3 +--
 dlls/kernel32/tests/profile.c |    7 ++-----
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/dlls/kernel32/profile.c b/dlls/kernel32/profile.c
index 8b77aaa..fea858c 100644
--- a/dlls/kernel32/profile.c
+++ b/dlls/kernel32/profile.c
@@ -1446,8 +1446,7 @@ BOOL WINAPI WritePrivateProfileStringW( LPCWSTR section, LPCWSTR entry,
     else if (PROFILE_Open( filename, TRUE ))
     {
         if (!section) {
-            FIXME("(NULL?,%s,%s,%s)?\n",
-                  debugstr_w(entry), debugstr_w(string), debugstr_w(filename));
+            SetLastError(ERROR_FILE_NOT_FOUND);
         } else {
             ret = PROFILE_SetString( section, entry, string, FALSE);
             PROFILE_FlushFile();
diff --git a/dlls/kernel32/tests/profile.c b/dlls/kernel32/tests/profile.c
index 6000ffb..0ba3fd1 100644
--- a/dlls/kernel32/tests/profile.c
+++ b/dlls/kernel32/tests/profile.c
@@ -855,11 +855,8 @@ static void test_WritePrivateProfileString(void)
     SetLastError(0xdeadbeef);
     ret = WritePrivateProfileStringA(NULL, "key", "string", path);
     ok(ret == FALSE, "Expected FALSE, got %d\n", ret);
-    todo_wine
-    {
-        ok(GetLastError() == ERROR_FILE_NOT_FOUND,
-           "Expected ERROR_FILE_NOT_FOUND, got %d\n", GetLastError());
-    }
+    ok(GetLastError() == ERROR_FILE_NOT_FOUND,
+       "Expected ERROR_FILE_NOT_FOUND, got %d\n", GetLastError());
     ok(check_file_data(path, data), "File doesn't match\n");
     DeleteFileA(path);
 




More information about the wine-cvs mailing list