Rob Shearman : rpcrt4: Fix potential NULL pointer access in process_bind_packet.
Alexandre Julliard
julliard at winehq.org
Mon Nov 16 11:43:53 CST 2009
Module: wine
Branch: master
Commit: eb0d2828b243a751628dd4b5467d1dace9f32767
URL: http://source.winehq.org/git/wine.git/?a=commit;h=eb0d2828b243a751628dd4b5467d1dace9f32767
Author: Rob Shearman <robertshearman at gmail.com>
Date: Fri Nov 13 22:47:10 2009 +0000
rpcrt4: Fix potential NULL pointer access in process_bind_packet.
Upon failure to allocate results in process_bind_packet, build nack
packet and send right away, instead of falling into the normal path
and potentially dereferencing the NULL pointer.
---
dlls/rpcrt4/rpc_server.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/dlls/rpcrt4/rpc_server.c b/dlls/rpcrt4/rpc_server.c
index 1bd1235..84e8854 100644
--- a/dlls/rpcrt4/rpc_server.c
+++ b/dlls/rpcrt4/rpc_server.c
@@ -203,6 +203,7 @@ static RPC_STATUS process_bind_packet(RpcConnection *conn, RpcPktBindHdr *hdr, R
response = RPCRT4_BuildBindNackHeader(NDR_LOCAL_DATA_REPRESENTATION,
RPC_VER_MAJOR, RPC_VER_MINOR,
REJECT_LOCAL_LIMIT_EXCEEDED);
+ goto send;
}
for (i = 0, ctxt_elem = (RpcContextElement *)msg->Buffer;
More information about the wine-cvs
mailing list