Alexander Nicolaysen Sørnes : testData: Add Installs? option of 'No, but has workaround'
Alexander Nicolaysen Sørnes
asornes at winehq.org
Tue Nov 17 17:35:46 CST 2009
Module: appdb
Branch: master
Commit: 0df84bdc05fc5fad39304bda89a8450f88b083e0
URL: http://source.winehq.org/git/appdb.git/?a=commit;h=0df84bdc05fc5fad39304bda89a8450f88b083e0
Author: Alexander Nicolaysen Sørnes <alexander at linux-xqqm.(none)>
Date: Sun Nov 15 20:26:53 2009 +0100
testData: Add Installs? option of 'No, but has workaround'
---
include/testData.php | 8 ++++----
tables/testResults.sql | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/testData.php b/include/testData.php
index e565bee..5b6f1cb 100644
--- a/include/testData.php
+++ b/include/testData.php
@@ -1012,16 +1012,16 @@ class testData{
if (($aValues['sRuns'] != "Yes") && ($aValues['sTestedRating'] != GARBAGE_RATING))
$errors .= "<li>Applications that do not run should be rated ‘Garbage’.</li>\n";
- if (($aValues['sInstalls'] == "No") && ($aValues['sTestedRating'] == PLATINUM_RATING))
+ if (($aValues['sInstalls'] == "No" || $aValues['sInstalls'] == 'No, but has workaround') && ($aValues['sTestedRating'] == PLATINUM_RATING))
$errors .= "<li>An application can only get a Platinum rating if it installs and runs ‘out of the box’.</li>\n";
// Basic checking of logic. Runs? can obviously only be 'Not Installable'
// if the application does not install
if (($aValues['sInstalls'] != "No") && ($aValues['sRuns'] == "Not installable"))
- $errors .= "<li>You can only set Runs? to ‘Not installable’ if the application's installer does not work</li>\n";
+ $errors .= "<li>You can only set Runs? to ‘Not installable’ if Installs? is set ‘No’</li>\n";
if (($aValues['sInstalls'] == "No") && ($aValues['sRuns'] != "Not installable"))
- $errors .= "<li>You can only set Runs? to ‘Not installable’' if the application's installer does not work</li>\n";
+ $errors .= "<li>Runs? must be set to ‘Not installable’ if there is no way to install the app</li>\n";
return $errors;
@@ -1053,7 +1053,7 @@ class testData{
{
echo "<select name='$sVarname'>\n";
echo "<option value=\"\">Choose ...</option>\n";
- $aRating = array("Yes", "No", "N/A");
+ $aRating = array('Yes', 'No', 'No, but has workaround', 'N/A');
$iMax = count($aRating);
for($i=0; $i < $iMax; $i++)
diff --git a/tables/testResults.sql b/tables/testResults.sql
index dd0d899..7f88a54 100644
--- a/tables/testResults.sql
+++ b/tables/testResults.sql
@@ -14,7 +14,7 @@ create table testResults (
testedDate datetime not null,
distributionId int not null,
testedRelease tinytext,
- installs enum('Yes','No','N/A') NOT NULL default 'Yes',
+ installs enum('Yes','No','No, but has workaround','N/A') NOT NULL default 'Yes',
runs enum('Yes','No','Not Installable') NOT NULL default 'Yes',
testedRating enum('Platinum','Gold','Silver','Bronze','Garbage') NOT NULL,
comments text,
More information about the wine-cvs
mailing list