Owen Rudge : shell32: Don't increase refcount twice in SHGetImageList.

Alexandre Julliard julliard at winehq.org
Thu Nov 19 10:15:20 CST 2009


Module: wine
Branch: master
Commit: ed5a2992f372dcbebf00abe52351bbc375a7b474
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=ed5a2992f372dcbebf00abe52351bbc375a7b474

Author: Owen Rudge <orudge at codeweavers.com>
Date:   Wed Nov 18 14:44:10 2009 -0600

shell32: Don't increase refcount twice in SHGetImageList.

---

 dlls/shell32/shellord.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/dlls/shell32/shellord.c b/dlls/shell32/shellord.c
index 7aa3a0c..be601a1 100644
--- a/dlls/shell32/shellord.c
+++ b/dlls/shell32/shellord.c
@@ -2203,9 +2203,7 @@ HRESULT WINAPI SHGetImageList(int iImageList, REFIID riid, void **ppv)
     if (hNew)
     {
         ret = HIMAGELIST_QueryInterface(hNew, riid, ppv);
-
-        if (!SUCCEEDED(ret))
-            ImageList_Destroy(hNew);
+        ImageList_Destroy(hNew);
     }
 
     return ret;




More information about the wine-cvs mailing list