Juan Lang : crypt32: Finding a CRL issued by a cert should compare the cert 's subject, not its issuer.

Alexandre Julliard julliard at winehq.org
Mon Nov 23 08:49:50 CST 2009


Module: wine
Branch: master
Commit: 8646c39bdbe8b2ca451059382c4ff2316a92ca74
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=8646c39bdbe8b2ca451059382c4ff2316a92ca74

Author: Juan Lang <juan.lang at gmail.com>
Date:   Fri Nov 20 14:46:53 2009 -0800

crypt32: Finding a CRL issued by a cert should compare the cert's subject, not its issuer.

---

 dlls/crypt32/crl.c       |    2 +-
 dlls/crypt32/tests/crl.c |    2 --
 2 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/dlls/crypt32/crl.c b/dlls/crypt32/crl.c
index 9e7fe9d..b8e8182 100644
--- a/dlls/crypt32/crl.c
+++ b/dlls/crypt32/crl.c
@@ -115,7 +115,7 @@ static BOOL compare_crl_issued_by(PCCRL_CONTEXT pCrlContext, DWORD dwType,
         PCCERT_CONTEXT issuer = pvPara;
 
         ret = CertCompareCertificateName(issuer->dwCertEncodingType,
-         &issuer->pCertInfo->Issuer, &pCrlContext->pCrlInfo->Issuer);
+         &issuer->pCertInfo->Subject, &pCrlContext->pCrlInfo->Issuer);
         if (ret && (dwFlags & CRL_FIND_ISSUED_BY_SIGNATURE_FLAG))
             ret = CryptVerifyCertificateSignatureEx(0,
              issuer->dwCertEncodingType,
diff --git a/dlls/crypt32/tests/crl.c b/dlls/crypt32/tests/crl.c
index cdb327f..abf2fd0 100644
--- a/dlls/crypt32/tests/crl.c
+++ b/dlls/crypt32/tests/crl.c
@@ -651,11 +651,9 @@ static void testFindCRL(void)
                 revoked_count++;
         }
     } while (context);
-    todo_wine {
     ok(count == 0, "expected 0 matching CRLs, got %d\n", count);
     ok(revoked_count == 0, "expected 0 matching CRL entries, got %d\n",
      revoked_count);
-    }
     count = revoked_count = 0;
     do {
         context = pCertFindCRLInStore(store, 0, 0, CRL_FIND_ISSUED_BY,




More information about the wine-cvs mailing list