Hans Leidekker : wininet: Avoid accessing uninitialized memory.

Alexandre Julliard julliard at winehq.org
Fri Oct 23 10:19:01 CDT 2009


Module: wine
Branch: master
Commit: 0f127fc7a1836c287e88995a086539a997108569
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=0f127fc7a1836c287e88995a086539a997108569

Author: Hans Leidekker <hans at codeweavers.com>
Date:   Fri Oct 23 10:49:22 2009 +0200

wininet: Avoid accessing uninitialized memory.

Found by valgrind.

---

 dlls/wininet/ftp.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/wininet/ftp.c b/dlls/wininet/ftp.c
index 8894add..b0dc695 100644
--- a/dlls/wininet/ftp.c
+++ b/dlls/wininet/ftp.c
@@ -716,9 +716,9 @@ HINTERNET WINAPI FtpFindFirstFileA(HINTERNET hConnect,
     ret = FtpFindFirstFileW(hConnect, lpwzSearchFile, lpFindFileDataW, dwFlags, dwContext);
     HeapFree(GetProcessHeap(), 0, lpwzSearchFile);
     
-    if(lpFindFileData) {
+    if (ret && lpFindFileData)
         WININET_find_data_WtoA(lpFindFileDataW, lpFindFileData);
-    }
+
     return ret;
 }
 




More information about the wine-cvs mailing list