Henri Verbeet : wined3d: Print an ERR instead of crashing in context_check_fbo_status().

Alexandre Julliard julliard at winehq.org
Mon Oct 26 10:08:33 CDT 2009


Module: wine
Branch: master
Commit: 483d5d0a0d74c83aa140b9865ab73f2026a66568
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=483d5d0a0d74c83aa140b9865ab73f2026a66568

Author: Henri Verbeet <hverbeet at codeweavers.com>
Date:   Mon Oct 26 10:12:19 2009 +0100

wined3d: Print an ERR instead of crashing in context_check_fbo_status().

Some version of Mesa will claim the window system provided framebuffer is
incomplete when using indirect rendering, although the framebuffer objects
spec says this can never happen. Printing an ERR instead of crashing should
make it clearer that this isn't a wined3d problem.

---

 dlls/wined3d/context.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/dlls/wined3d/context.c b/dlls/wined3d/context.c
index 66ba358..de50f9e 100644
--- a/dlls/wined3d/context.c
+++ b/dlls/wined3d/context.c
@@ -288,6 +288,12 @@ static void context_check_fbo_status(struct wined3d_context *context)
         unsigned int i;
         FIXME("FBO status %s (%#x)\n", debug_fbostatus(status), status);
 
+        if (!context->current_fbo)
+        {
+            ERR("FBO 0 is incomplete, driver bug?\n");
+            return;
+        }
+
         /* Dump the FBO attachments */
         for (i = 0; i < gl_info->max_buffers; ++i)
         {




More information about the wine-cvs mailing list