Peter Oberndorfer : shlwapi: Remove pointer check in IStream::Clone, it also crashes on Windows.
Alexandre Julliard
julliard at winehq.org
Tue Sep 29 11:09:06 CDT 2009
Module: wine
Branch: master
Commit: a35fd4f496fcd2898b15051fa2b96598c5581cfb
URL: http://source.winehq.org/git/wine.git/?a=commit;h=a35fd4f496fcd2898b15051fa2b96598c5581cfb
Author: Peter Oberndorfer <kumbayo84 at arcor.de>
Date: Mon Sep 28 22:24:10 2009 +0200
shlwapi: Remove pointer check in IStream::Clone, it also crashes on Windows.
Add comments to functions that are not implemented.
---
dlls/shlwapi/regstream.c | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/dlls/shlwapi/regstream.c b/dlls/shlwapi/regstream.c
index cd48d93..c167843 100644
--- a/dlls/shlwapi/regstream.c
+++ b/dlls/shlwapi/regstream.c
@@ -234,6 +234,8 @@ static HRESULT WINAPI IStream_fnCopyTo (IStream * iface, IStream* pstm, ULARGE_I
pcbRead->QuadPart = 0;
if (pcbWritten)
pcbWritten->QuadPart = 0;
+
+ /* TODO implement */
return E_NOTIMPL;
}
@@ -246,6 +248,7 @@ static HRESULT WINAPI IStream_fnCommit (IStream * iface, DWORD grfCommitFlags)
TRACE("(%p)\n",This);
+ /* commit not supported by this stream */
return E_NOTIMPL;
}
@@ -258,6 +261,7 @@ static HRESULT WINAPI IStream_fnRevert (IStream * iface)
TRACE("(%p)\n",This);
+ /* revert not supported by this stream */
return E_NOTIMPL;
}
@@ -270,6 +274,7 @@ static HRESULT WINAPI IStream_fnLockUnlockRegion (IStream * iface, ULARGE_INTEGE
TRACE("(%p)\n",This);
+ /* lock/unlock not supported by this stream */
return E_NOTIMPL;
}
@@ -308,8 +313,9 @@ static HRESULT WINAPI IStream_fnClone (IStream * iface, IStream** ppstm)
ISHRegStream *This = (ISHRegStream *)iface;
TRACE("(%p)\n",This);
- if (ppstm)
- *ppstm = NULL;
+ *ppstm = NULL;
+
+ /* clone not supported by this stream */
return E_NOTIMPL;
}
More information about the wine-cvs
mailing list