Hans Leidekker : msi: Release summary information on error in msi_parse_patch_summary.

Alexandre Julliard julliard at winehq.org
Tue Apr 13 11:24:41 CDT 2010


Module: wine
Branch: master
Commit: bcc0ad9b079b76e0c90969cdd791c81b77a9c933
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=bcc0ad9b079b76e0c90969cdd791c81b77a9c933

Author: Hans Leidekker <hans at codeweavers.com>
Date:   Tue Apr 13 11:15:55 2010 +0200

msi: Release summary information on error in msi_parse_patch_summary.

---

 dlls/msi/action.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/dlls/msi/action.c b/dlls/msi/action.c
index 3322371..5043426 100644
--- a/dlls/msi/action.c
+++ b/dlls/msi/action.c
@@ -501,16 +501,23 @@ static UINT msi_parse_patch_summary( MSIPACKAGE *package, MSIDATABASE *patch_db
     if (msi_check_patch_applicable( package, si ) != ERROR_SUCCESS)
     {
         TRACE("Patch not applicable\n");
+        msiobj_release( &si->hdr );
         return ERROR_SUCCESS;
     }
 
     package->patch = msi_alloc(sizeof(MSIPATCHINFO));
     if (!package->patch)
+    {
+        msiobj_release( &si->hdr );
         return ERROR_OUTOFMEMORY;
+    }
 
     package->patch->patchcode = msi_suminfo_dup_string(si, PID_REVNUMBER);
     if (!package->patch->patchcode)
+    {
+        msiobj_release( &si->hdr );
         return ERROR_OUTOFMEMORY;
+    }
 
     /* enumerate the substorage */
     str = msi_suminfo_dup_string( si, PID_LASTAUTHOR );




More information about the wine-cvs mailing list