Juan Lang : wintrust: Fix uninitialized return value (Coverity).

Alexandre Julliard julliard at winehq.org
Tue Feb 2 10:45:27 CST 2010


Module: wine
Branch: master
Commit: 0f632c0caf124914b2a233909f2f08946ee80a3d
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=0f632c0caf124914b2a233909f2f08946ee80a3d

Author: Juan Lang <juan.lang at gmail.com>
Date:   Mon Feb  1 09:11:51 2010 -0800

wintrust: Fix uninitialized return value (Coverity).

---

 dlls/wintrust/softpub.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/dlls/wintrust/softpub.c b/dlls/wintrust/softpub.c
index 3e79172..852976a 100644
--- a/dlls/wintrust/softpub.c
+++ b/dlls/wintrust/softpub.c
@@ -284,7 +284,7 @@ error:
 
 static DWORD SOFTPUB_LoadCertMessage(CRYPT_PROVIDER_DATA *data)
 {
-    DWORD err;
+    DWORD err = ERROR_SUCCESS;
 
     if (data->pWintrustData->u.pCert &&
      WVT_IS_CBSTRUCT_GT_MEMBEROFFSET(WINTRUST_CERT_INFO,
@@ -325,11 +325,6 @@ static DWORD SOFTPUB_LoadCertMessage(CRYPT_PROVIDER_DATA *data)
             if (!ret)
                 err = GetLastError();
         }
-        else
-        {
-            /* Do nothing!?  See the tests */
-            err = ERROR_SUCCESS;
-        }
     }
     else
         err = ERROR_INVALID_PARAMETER;




More information about the wine-cvs mailing list