Michael Stefaniuc : hhctrl.ocx: Use the SendMessage instead of ListView_GetItem.

Alexandre Julliard julliard at winehq.org
Wed Feb 10 10:44:51 CST 2010


Module: wine
Branch: master
Commit: 968f21477236966ac9bf9f1fb7c221f1c9ff2553
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=968f21477236966ac9bf9f1fb7c221f1c9ff2553

Author: Michael Stefaniuc <mstefani at redhat.de>
Date:   Tue Feb  9 23:02:03 2010 +0100

hhctrl.ocx: Use the SendMessage instead of ListView_GetItem.

SendMessage() is more explicit and also gets rid of three gcc -Wextra
  warning: value computed is not used

---

 dlls/hhctrl.ocx/help.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/hhctrl.ocx/help.c b/dlls/hhctrl.ocx/help.c
index 680911a..30cb008 100644
--- a/dlls/hhctrl.ocx/help.c
+++ b/dlls/hhctrl.ocx/help.c
@@ -550,7 +550,7 @@ static LRESULT CALLBACK Child_WndProc(HWND hWnd, UINT message, WPARAM wParam, LP
 
                 lvItem.iItem = (int) SendMessageW(hwndList, LVM_GETSELECTIONMARK, 0, 0);
                 lvItem.mask = TVIF_PARAM;
-                ListView_GetItemW(hwndList, &lvItem);
+                SendMessageW(hwndList, LVM_GETITEMW, 0, (LPARAM)&lvItem);
                 OnTopicChange(info, (void*) lvItem.lParam);
                 return 0;
             }
@@ -578,7 +578,7 @@ static LRESULT CALLBACK Child_WndProc(HWND hWnd, UINT message, WPARAM wParam, LP
 
                     lvItem.iItem = (int) SendMessageW(hwndList, LVM_GETSELECTIONMARK, 0, 0);
                     lvItem.mask = TVIF_PARAM;
-                    ListView_GetItemW(hwndList, &lvItem);
+                    SendMessageW(hwndList, LVM_GETITEMW, 0, (LPARAM)&lvItem);
                     OnTopicChange(info, (void*) lvItem.lParam);
                     return 0;
                 }
@@ -1095,7 +1095,7 @@ static LRESULT CALLBACK PopupChild_WndProc(HWND hWnd, UINT message, WPARAM wPara
 
             lvItem.iItem = (int) SendMessageW(info->popup.hwndList, LVM_GETSELECTIONMARK, 0, 0);
             lvItem.mask = TVIF_PARAM;
-            ListView_GetItemW(info->popup.hwndList, &lvItem);
+            SendMessageW(info->popup.hwndList, LVM_GETITEMW, 0, (LPARAM)&lvItem);
             iter = (IndexSubItem*) lvItem.lParam;
             NavigateToChm(info, info->index->merge.chm_file, iter->local);
             ShowWindow(info->popup.hwndPopup, SW_HIDE);




More information about the wine-cvs mailing list