Andrew Nguyen : setupapi: Avoid useless initializations in SetupIterateCabinetA/W.

Alexandre Julliard julliard at winehq.org
Wed Jun 16 13:23:22 CDT 2010


Module: wine
Branch: master
Commit: 7057637ff060d423259d109fd42760bfcb8d8b7b
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=7057637ff060d423259d109fd42760bfcb8d8b7b

Author: Andrew Nguyen <anguyen at codeweavers.com>
Date:   Tue Jun 15 05:20:08 2010 -0500

setupapi: Avoid useless initializations in SetupIterateCabinetA/W.

---

 dlls/setupapi/setupcab.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)

diff --git a/dlls/setupapi/setupcab.c b/dlls/setupapi/setupcab.c
index d879f9d..0dd2d86 100644
--- a/dlls/setupapi/setupcab.c
+++ b/dlls/setupapi/setupcab.c
@@ -563,13 +563,9 @@ BOOL WINAPI SetupIterateCabinetA(PCSTR CabinetFile, DWORD Reserved,
   TRACE("(CabinetFile == %s, Reserved == %u, MsgHandler == ^%p, Context == ^%p)\n",
         debugstr_a(CabinetFile), Reserved, MsgHandler, Context);
 
-  if (! LoadCABINETDll()) 
+  if (!LoadCABINETDll())
     return FALSE;
 
-  memset(&my_hsc, 0, sizeof(SC_HSC_A));
-  pszCabinet[0] = '\0';
-  pszCabPath[0] = '\0';
-
   fpnsize = strlen(CabinetFile);
   if (fpnsize >= MAX_PATH) {
     SetLastError(ERROR_BAD_PATHNAME);
@@ -633,8 +629,6 @@ BOOL WINAPI SetupIterateCabinetW(PCWSTR CabinetFile, DWORD Reserved,
 
   if (!CabinetFile) return FALSE;
 
-  memset(&my_hsc, 0, sizeof(SC_HSC_W));
-
   fpnsize = GetFullPathNameW(CabinetFile, MAX_PATH, pszCabPathW, &p);
   if (fpnsize > MAX_PATH) {
     SetLastError(ERROR_BAD_PATHNAME);




More information about the wine-cvs mailing list