Jacek Caban : mshtml: Don' t free string that will be cleared by SafeArrayDestroy.

Alexandre Julliard julliard at winehq.org
Mon Nov 8 11:46:23 CST 2010


Module: wine
Branch: master
Commit: 645f34ddeba6e273b56a85b1eac53fba072adf55
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=645f34ddeba6e273b56a85b1eac53fba072adf55

Author: Jacek Caban <jacek at codeweavers.com>
Date:   Mon Nov  8 12:48:26 2010 +0100

mshtml: Don't free string that will be cleared by SafeArrayDestroy.

---

 dlls/mshtml/tests/dom.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c
index ec3e4ef..f472768 100644
--- a/dlls/mshtml/tests/dom.c
+++ b/dlls/mshtml/tests/dom.c
@@ -5693,7 +5693,6 @@ static void doc_write(IHTMLDocument2 *doc, BOOL ln, const char *text)
     SAFEARRAYBOUND dim;
     SAFEARRAY *sa;
     VARIANT *var;
-    BSTR str;
     HRESULT hres;
 
     dim.lLbound = 0;
@@ -5701,7 +5700,7 @@ static void doc_write(IHTMLDocument2 *doc, BOOL ln, const char *text)
     sa = SafeArrayCreate(VT_VARIANT, 1, &dim);
     SafeArrayAccessData(sa, (void**)&var);
     V_VT(var) = VT_BSTR;
-    V_BSTR(var) = str = a2bstr(text);
+    V_BSTR(var) = a2bstr(text);
     SafeArrayUnaccessData(sa);
 
     if(ln)
@@ -5710,7 +5709,6 @@ static void doc_write(IHTMLDocument2 *doc, BOOL ln, const char *text)
         hres = IHTMLDocument2_write(doc, sa);
     ok(hres == S_OK, "write failed: %08x\n", hres);
 
-    SysFreeString(str);
     SafeArrayDestroy(sa);
 }
 




More information about the wine-cvs mailing list