Andrew Eikum : shell32: PIDLs should be checked recursively in SHChangeNotify.

Alexandre Julliard julliard at winehq.org
Mon Nov 15 13:28:45 CST 2010


Module: wine
Branch: master
Commit: b75b9fab2f2b10c68a7473512a461492b0dce190
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=b75b9fab2f2b10c68a7473512a461492b0dce190

Author: Andrew Eikum <aeikum at codeweavers.com>
Date:   Fri Nov 12 15:32:55 2010 -0600

shell32: PIDLs should be checked recursively in SHChangeNotify.

---

 dlls/shell32/changenotify.c    |    2 +-
 dlls/shell32/tests/shlfolder.c |    1 +
 2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/dlls/shell32/changenotify.c b/dlls/shell32/changenotify.c
index 95f2e42..43c81c3 100644
--- a/dlls/shell32/changenotify.c
+++ b/dlls/shell32/changenotify.c
@@ -243,7 +243,7 @@ static BOOL should_notify( LPCITEMIDLIST changed, LPCITEMIDLIST watched, BOOL su
         return FALSE;
     if (ILIsEqual( watched, changed ) )
         return TRUE;
-    if( sub && ILIsParent( watched, changed, TRUE ) )
+    if( sub && ILIsParent( watched, changed, FALSE ) )
         return TRUE;
     return FALSE;
 }
diff --git a/dlls/shell32/tests/shlfolder.c b/dlls/shell32/tests/shlfolder.c
index 43b721d..31ef752 100644
--- a/dlls/shell32/tests/shlfolder.c
+++ b/dlls/shell32/tests/shlfolder.c
@@ -4218,6 +4218,7 @@ struct ChNotifyTest {
     const char path_2[256];
 } chnotify_tests[] = {
     {"MKDIR", 1, 0, SHCNE_MKDIR, "C:\\shell32_cn_test\\test", ""},
+    {"CREATE", 1, 0, SHCNE_CREATE, "C:\\shell32_cn_test\\test\\file.txt", ""},
     {"RMDIR", 1, 0, SHCNE_RMDIR, "C:\\shell32_cn_test\\test", ""},
 };
 




More information about the wine-cvs mailing list