Hans Leidekker : msi: Store action data for deferred rollback actions too.

Alexandre Julliard julliard at winehq.org
Wed Oct 13 11:43:10 CDT 2010


Module: wine
Branch: master
Commit: 5d0a6b000446a7001c8da75f294ad3b5ac37acac
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=5d0a6b000446a7001c8da75f294ad3b5ac37acac

Author: Hans Leidekker <hans at codeweavers.com>
Date:   Wed Oct 13 14:24:01 2010 +0200

msi: Store action data for deferred rollback actions too.

---

 dlls/msi/custom.c |   16 +++++++---------
 1 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/dlls/msi/custom.c b/dlls/msi/custom.c
index e3a2b44..b56139f 100644
--- a/dlls/msi/custom.c
+++ b/dlls/msi/custom.c
@@ -222,13 +222,6 @@ UINT ACTION_CustomAction(MSIPACKAGE *package, LPCWSTR action, UINT script, BOOL
         if (type & msidbCustomActionTypeNoImpersonate)
             WARN("msidbCustomActionTypeNoImpersonate not handled\n");
 
-        if (type & msidbCustomActionTypeRollback)
-        {
-            FIXME("Rollback only action... rollbacks not supported yet\n");
-            schedule_action(package, ROLLBACK_SCRIPT, action);
-            rc = ERROR_SUCCESS;
-            goto end;
-        }
         if (!execute)
         {
             LPWSTR actiondata = msi_dup_property(package->db, action);
@@ -238,12 +231,17 @@ UINT ACTION_CustomAction(MSIPACKAGE *package, LPCWSTR action, UINT script, BOOL
 
             if (type & msidbCustomActionTypeCommit)
             {
-                TRACE("Deferring Commit Action!\n");
+                TRACE("Deferring commit action\n");
                 schedule_action(package, COMMIT_SCRIPT, deferred);
             }
+            else if (type & msidbCustomActionTypeRollback)
+            {
+                FIXME("Deferring rollback only action... rollbacks not supported yet\n");
+                schedule_action(package, ROLLBACK_SCRIPT, deferred);
+            }
             else
             {
-                TRACE("Deferring Action!\n");
+                TRACE("Deferring action\n");
                 schedule_action(package, INSTALL_SCRIPT, deferred);
             }
 




More information about the wine-cvs mailing list