Michael Stefaniuc : urlmon: Remove superfluous NULL check before heap_free (Smatch).

Alexandre Julliard julliard at winehq.org
Wed Sep 8 13:32:11 CDT 2010


Module: wine
Branch: master
Commit: de9f0b98d432cbee69b9137ab78d10b53bc0b581
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=de9f0b98d432cbee69b9137ab78d10b53bc0b581

Author: Michael Stefaniuc <mstefani at redhat.de>
Date:   Tue Sep  7 23:10:56 2010 +0200

urlmon: Remove superfluous NULL check before heap_free (Smatch).

---

 dlls/urlmon/uri.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/dlls/urlmon/uri.c b/dlls/urlmon/uri.c
index 94be29b..dbe6d72 100644
--- a/dlls/urlmon/uri.c
+++ b/dlls/urlmon/uri.c
@@ -3310,8 +3310,7 @@ static HRESULT get_builder_component(LPWSTR *component, DWORD *component_len,
 static HRESULT set_builder_component(LPWSTR *component, DWORD *component_len, LPCWSTR new_value,
                                      WCHAR prefix, DWORD *flags, DWORD success_flag)
 {
-    if(*component)
-        heap_free(*component);
+    heap_free(*component);
 
     if(!new_value) {
         *component = NULL;




More information about the wine-cvs mailing list