Andrew Nguyen : iphlpapi: Remove useless loop and initialize gateway linked list next member to NULL .

Alexandre Julliard julliard at winehq.org
Mon Sep 27 11:29:38 CDT 2010


Module: wine
Branch: master
Commit: fea9d8f171db15bfa80bd278e9e43eafab8e07e5
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=fea9d8f171db15bfa80bd278e9e43eafab8e07e5

Author: Andrew Nguyen <anguyen at codeweavers.com>
Date:   Mon Sep 27 04:30:38 2010 -0500

iphlpapi: Remove useless loop and initialize gateway linked list next member to NULL.

---

 dlls/iphlpapi/iphlpapi_main.c |   17 ++++-------------
 1 files changed, 4 insertions(+), 13 deletions(-)

diff --git a/dlls/iphlpapi/iphlpapi_main.c b/dlls/iphlpapi/iphlpapi_main.c
index d6e568f..079ebff 100644
--- a/dlls/iphlpapi/iphlpapi_main.c
+++ b/dlls/iphlpapi/iphlpapi_main.c
@@ -813,19 +813,9 @@ static ULONG adapterAddressesFromIndex(ULONG family, DWORD index, IP_ADAPTER_ADD
                 PIP_ADAPTER_GATEWAY_ADDRESS gw;
                 PSOCKADDR_IN sin;
 
-                for (gw = aa->FirstGatewayAddress; gw && gw->Next;
-                     gw = gw->Next)
-                    ;
-                if (!gw)
-                {
-                    gw = (PIP_ADAPTER_GATEWAY_ADDRESS)ptr;
-                    aa->FirstGatewayAddress = gw;
-                }
-                else
-                {
-                    gw->Next = (PIP_ADAPTER_GATEWAY_ADDRESS)ptr;
-                    gw = gw->Next;
-                }
+                gw = (PIP_ADAPTER_GATEWAY_ADDRESS)ptr;
+                aa->FirstGatewayAddress = gw;
+
                 gw->u.s.Length = sizeof(IP_ADAPTER_GATEWAY_ADDRESS);
                 ptr += sizeof(IP_ADAPTER_GATEWAY_ADDRESS);
                 sin = (PSOCKADDR_IN)ptr;
@@ -835,6 +825,7 @@ static ULONG adapterAddressesFromIndex(ULONG family, DWORD index, IP_ADAPTER_ADD
                        sizeof(DWORD));
                 gw->Address.lpSockaddr = (LPSOCKADDR)sin;
                 gw->Address.iSockaddrLength = sizeof(SOCKADDR_IN);
+                gw->Next = NULL;
                 ptr += sizeof(SOCKADDR_IN);
             }
         }




More information about the wine-cvs mailing list