Ričardas Barkauskas : ddraw/tests: Properly release no longer used interfaces.

Alexandre Julliard julliard at winehq.org
Mon Aug 22 13:29:13 CDT 2011


Module: wine
Branch: master
Commit: 1a609ecab81bfa90d1aa3afbae0711e728f4e643
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=1a609ecab81bfa90d1aa3afbae0711e728f4e643

Author: Ričardas Barkauskas <rbarkauskas at codeweavers.com>
Date:   Mon Aug  8 01:25:54 2011 +0300

ddraw/tests: Properly release no longer used interfaces.

---

 dlls/ddraw/tests/d3d.c      |    4 ++--
 dlls/ddraw/tests/dsurface.c |    5 ++++-
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/dlls/ddraw/tests/d3d.c b/dlls/ddraw/tests/d3d.c
index 0df3780..2197c64 100644
--- a/dlls/ddraw/tests/d3d.c
+++ b/dlls/ddraw/tests/d3d.c
@@ -1365,8 +1365,8 @@ static void Direct3D1Test(void)
     /* Interface consistency check. */
     hr = IDirect3DDevice_GetDirect3D(Direct3DDevice1, &Direct3D_alt);
     ok(hr == D3D_OK, "IDirect3DDevice_GetDirect3D failed: %08x\n", hr);
-    if (hr == D3D_OK)
-        ok(Direct3D_alt == Direct3D1, "Direct3D1 struct pointer missmatch: %p != %p\n", Direct3D_alt, Direct3D1);
+    ok(Direct3D_alt == Direct3D1, "Direct3D1 struct pointer missmatch: %p != %p\n", Direct3D_alt, Direct3D1);
+    IDirect3D_Release(Direct3D_alt);
 
     memset(&desc, 0, sizeof(desc));
     desc.dwSize = sizeof(desc);
diff --git a/dlls/ddraw/tests/dsurface.c b/dlls/ddraw/tests/dsurface.c
index b1a2940..1bbf5cc 100644
--- a/dlls/ddraw/tests/dsurface.c
+++ b/dlls/ddraw/tests/dsurface.c
@@ -3159,6 +3159,8 @@ static void GetDCTest(void)
     hr = IDirectDrawSurface4_ReleaseDC(surf4, dc);
     ok(SUCCEEDED(hr), "ReleaseDC failed, hr %#x.\n", hr);
 
+    IDirectDrawSurface_Release(tmp);
+
     dc = CreateCompatibleDC(NULL);
     ok(!!dc, "CreateCompatibleDC failed.\n");
 
@@ -3175,11 +3177,12 @@ static void GetDCTest(void)
     ok(!tmp, "Expected surface NULL, got %p.\n", tmp);
 
     IDirectDrawSurface4_Release(surf4);
+    IDirectDrawSurface_Release(surf);
     IDirectDraw4_Release(dd4);
 
     hr = IDirectDraw_QueryInterface(lpDD, &IID_IDirectDraw7, (void **) &dd7);
     ok(hr == DD_OK, "IDirectDraw_QueryInterface failed: 0x%08x\n", hr);
-    surf = NULL;
+
     hr = IDirectDraw7_CreateSurface(dd7, &ddsd2, &surf7, NULL);
     ok(hr == DD_OK, "IDirectDraw7_CreateSurface failed: 0x%08x\n", hr);
     dctest_surf((IDirectDrawSurface *) surf7, 2);




More information about the wine-cvs mailing list