Austin English : shell32/tests: Make sure return values are used (LLVM/ Clang).

Alexandre Julliard julliard at winehq.org
Mon Feb 14 10:02:04 CST 2011


Module: wine
Branch: master
Commit: 75f8de0d4f7fbd0b7d99e96bcd2730cb2bec83a8
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=75f8de0d4f7fbd0b7d99e96bcd2730cb2bec83a8

Author: Austin English <austinenglish at gmail.com>
Date:   Thu Feb 10 13:28:13 2011 -0800

shell32/tests: Make sure return values are used (LLVM/Clang).

---

 dlls/shell32/tests/shelllink.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/dlls/shell32/tests/shelllink.c b/dlls/shell32/tests/shelllink.c
index bdcffde..d28cff0 100644
--- a/dlls/shell32/tests/shelllink.c
+++ b/dlls/shell32/tests/shelllink.c
@@ -431,7 +431,7 @@ void create_lnk_(int line, const WCHAR* path, lnk_desc_t* desc, int save_fails)
     if (0)
     {
         /* crashes on XP */
-        r = IPersistFile_GetCurFile(pf, NULL);
+        IPersistFile_GetCurFile(pf, NULL);
     }
 
         /* test GetCurFile before ::Save */
@@ -760,6 +760,8 @@ static void test_load_save(void)
     check_lnk(lnkfile, &desc, 0x0);
 
     r=pGetShortPathNameA(mydir, mypath, sizeof(mypath));
+    ok(r<sizeof(mypath), "GetShortPathName failed (%d), err %d\n", r, GetLastError());
+
     strcpy(realpath, mypath);
     strcat(realpath, "\\test.txt");
     strcat(mypath, "\\\\test.txt");
@@ -809,6 +811,7 @@ static void test_load_save(void)
     check_lnk(lnkfile, &desc, 0x4);
 
     r = DeleteFileA(realpath);
+    ok(r, "failed to delete file %s (%d)\n", realpath, GetLastError());
 
     /* FIXME: Also test saving a .lnk pointing to a pidl that cannot be
      * represented as a path.
@@ -885,7 +888,7 @@ static void test_datalink(void)
 if (0)
 {
     /* the following crashes */
-    r = IShellLinkDataList_GetFlags( dl, NULL );
+    IShellLinkDataList_GetFlags( dl, NULL );
 }
 
     flags = 0;




More information about the wine-cvs mailing list