Hans Leidekker : Revert "advapi32: Fix cred domain according to tests.".

Alexandre Julliard julliard at winehq.org
Mon Jan 10 10:55:18 CST 2011


Module: wine
Branch: master
Commit: 3440e768dd0b6fff8791a394809f1e71fdeefd7f
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=3440e768dd0b6fff8791a394809f1e71fdeefd7f

Author: Hans Leidekker <hans at codeweavers.com>
Date:   Mon Jan 10 09:43:04 2011 +0100

Revert "advapi32: Fix cred domain according to tests.".

This reverts commit 061eb12ca39dc6dfd58c3bc2c16586da58fddac3.
The patch makes tests for CredRead and CredEnumerate pass but breaks
CredWrite at the same time.

---

 dlls/advapi32/cred.c       |    3 ---
 dlls/advapi32/tests/cred.c |    2 ++
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/dlls/advapi32/cred.c b/dlls/advapi32/cred.c
index 0afbb63..0c8c129 100644
--- a/dlls/advapi32/cred.c
+++ b/dlls/advapi32/cred.c
@@ -1821,9 +1821,6 @@ BOOL WINAPI CredWriteW(PCREDENTIALW Credential, DWORD Flags)
             SetLastError(ERROR_BAD_USERNAME);
             return FALSE;
         }
-
-        Credential->CredentialBlobSize = 0;
-        Credential->CredentialBlob = NULL;
     }
 
 #ifdef __APPLE__
diff --git a/dlls/advapi32/tests/cred.c b/dlls/advapi32/tests/cred.c
index 4d4e6c8..c2d9027 100644
--- a/dlls/advapi32/tests/cred.c
+++ b/dlls/advapi32/tests/cred.c
@@ -202,7 +202,9 @@ static void check_blob(int line, DWORD cred_type, PCREDENTIALA cred)
 {
     if (cred_type == CRED_TYPE_DOMAIN_PASSWORD)
     {
+        todo_wine
         ok_(__FILE__, line)(cred->CredentialBlobSize == 0, "expected CredentialBlobSize of 0 but got %d\n", cred->CredentialBlobSize);
+        todo_wine
         ok_(__FILE__, line)(!cred->CredentialBlob, "expected NULL credentials but got %p\n", cred->CredentialBlob);
     }
     else




More information about the wine-cvs mailing list