Hans Leidekker : msi: Use a return value (clang).

Alexandre Julliard julliard at winehq.org
Thu Jan 27 12:43:23 CST 2011


Module: wine
Branch: master
Commit: af3733cde55701ad9f27fd4273c13bf024dbc774
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=af3733cde55701ad9f27fd4273c13bf024dbc774

Author: Hans Leidekker <hans at codeweavers.com>
Date:   Thu Jan 27 11:55:38 2011 +0100

msi: Use a return value (clang).

---

 dlls/msi/custom.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/msi/custom.c b/dlls/msi/custom.c
index 8981e62..5e0cbe0 100644
--- a/dlls/msi/custom.c
+++ b/dlls/msi/custom.c
@@ -1184,13 +1184,13 @@ static DWORD ACTION_CallScript( const GUID *guid )
 {
     msi_custom_action_info *info;
     MSIHANDLE hPackage;
-    UINT r = ERROR_FUNCTION_FAILED;
+    UINT r;
 
     info = find_action_by_guid( guid );
     if (!info)
     {
         ERR("failed to find action %s\n", debugstr_guid( guid) );
-        return r;
+        return ERROR_FUNCTION_FAILED;
     }
 
     TRACE("function %s, script %s\n", debugstr_w( info->target ), debugstr_w( info->source ) );
@@ -1199,13 +1199,13 @@ static DWORD ACTION_CallScript( const GUID *guid )
     if (hPackage)
     {
         r = call_script( hPackage, info->type, info->source, info->target, info->action );
+        TRACE("script returned %u\n", r);
         MsiCloseHandle( hPackage );
     }
     else
         ERR("failed to create handle for %p\n", info->package );
 
     release_custom_action_data( info );
-
     return S_OK;
 }
 




More information about the wine-cvs mailing list