Marcus Meissner : ole32: Access the array entry, not the array (Coverity).

Alexandre Julliard julliard at winehq.org
Mon Jun 27 17:41:18 CDT 2011


Module: wine
Branch: master
Commit: 2395ea98bb61dcd3a468f615e7d5c8aa5d45be4d
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=2395ea98bb61dcd3a468f615e7d5c8aa5d45be4d

Author: Marcus Meissner <marcus at jet.franken.de>
Date:   Sun Jun 26 16:43:02 2011 +0200

ole32: Access the array entry, not the array (Coverity).

---

 dlls/ole32/stg_prop.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/ole32/stg_prop.c b/dlls/ole32/stg_prop.c
index cc29c0e..5eb0371 100644
--- a/dlls/ole32/stg_prop.c
+++ b/dlls/ole32/stg_prop.c
@@ -720,8 +720,8 @@ static HRESULT WINAPI IPropertyStorage_fnReadPropertyNames(
 
             hr = S_OK;
             rglpwstrName[i] = CoTaskMemAlloc((len + 1) * sizeof(WCHAR));
-            if (rglpwstrName)
-                memcpy(rglpwstrName, name, (len + 1) * sizeof(WCHAR));
+            if (rglpwstrName[i])
+                memcpy(rglpwstrName[i], name, (len + 1) * sizeof(WCHAR));
             else
                 hr = STG_E_INSUFFICIENTMEMORY;
         }




More information about the wine-cvs mailing list