Marcus Meissner : dmstyle: Reverse NULL check and deref (Coverity).

Alexandre Julliard julliard at winehq.org
Mon Jun 27 17:41:19 CDT 2011


Module: wine
Branch: master
Commit: e4d63f77114466ca808bbec3eba3821dd940b23f
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=e4d63f77114466ca808bbec3eba3821dd940b23f

Author: Marcus Meissner <marcus at jet.franken.de>
Date:   Sun Jun 26 16:57:51 2011 +0200

dmstyle: Reverse NULL check and deref (Coverity).

---

 dlls/dmstyle/style.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/dmstyle/style.c b/dlls/dmstyle/style.c
index eb6e77c..547025e 100644
--- a/dlls/dmstyle/style.c
+++ b/dlls/dmstyle/style.c
@@ -730,11 +730,11 @@ static HRESULT IDirectMusicStyle8Impl_IPersistStream_ParsePatternList (LPPERSIST
       TRACE_(dmfile)(": Pattern chunk\n");
       /** alloc new motif entry */
       pNewMotif = HeapAlloc (GetProcessHeap (), HEAP_ZERO_MEMORY, sizeof(DMUS_PRIVATE_STYLE_MOTIF));
-      list_add_tail (&This->Motifs, &pNewMotif->entry);
       if (NULL == pNewMotif) {
 	ERR(": no more memory\n");
 	return  E_OUTOFMEMORY;
       }
+      list_add_tail (&This->Motifs, &pNewMotif->entry);
 
       IStream_Read (pStm, &pNewMotif->pattern, Chunk.dwSize, NULL);
       /** TODO trace pattern */




More information about the wine-cvs mailing list