Marcus Meissner : msvcrt: Move side effect out of assert (Coverity).

Alexandre Julliard julliard at winehq.org
Fri Mar 4 09:39:37 CST 2011


Module: wine
Branch: master
Commit: ecb89ba89e63fcbb56e81d1cf7dbb371bdab1a51
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=ecb89ba89e63fcbb56e81d1cf7dbb371bdab1a51

Author: Marcus Meissner <meissner at suse.de>
Date:   Fri Mar  4 14:06:50 2011 +0100

msvcrt: Move side effect out of assert (Coverity).

---

 dlls/msvcrt/undname.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/dlls/msvcrt/undname.c b/dlls/msvcrt/undname.c
index 670873d..920a763 100644
--- a/dlls/msvcrt/undname.c
+++ b/dlls/msvcrt/undname.c
@@ -1184,7 +1184,8 @@ static BOOL handle_template(struct parsed_symbol* sym)
     const char* name;
     const char* args;
 
-    assert(*sym->current++ == '$');
+    assert(*sym->current == '$');
+    sym->current++;
     if (!(name = get_literal_string(sym))) return FALSE;
     if (!(args = get_args(sym, NULL, FALSE, '<', '>'))) return FALSE;
     sym->result = str_printf(sym, "%s%s", name, args);




More information about the wine-cvs mailing list