Juan Lang : setupapi: Always initialize output parameter to avoid crash in buggy applications.

Alexandre Julliard julliard at winehq.org
Mon May 16 11:36:46 CDT 2011


Module: wine
Branch: master
Commit: 53b287530961beaaae89bd063bc0d63ef41036ff
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=53b287530961beaaae89bd063bc0d63ef41036ff

Author: Juan Lang <juan.lang at gmail.com>
Date:   Sat May 14 14:55:28 2011 -0700

setupapi: Always initialize output parameter to avoid crash in buggy applications.

---

 dlls/setupapi/devinst.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/dlls/setupapi/devinst.c b/dlls/setupapi/devinst.c
index 5b8fb3c..0a3c3bd 100644
--- a/dlls/setupapi/devinst.c
+++ b/dlls/setupapi/devinst.c
@@ -2821,6 +2821,8 @@ BOOL WINAPI SetupDiEnumDeviceInterfaces(
         SetLastError(ERROR_INVALID_PARAMETER);
         return FALSE;
     }
+    /* In case application fails to check return value, clear output */
+    memset(DeviceInterfaceData, 0, sizeof(*DeviceInterfaceData));
     if (DeviceInfoData)
     {
         struct DeviceInfo *devInfo =




More information about the wine-cvs mailing list