Jacek Caban : mshtml: Don' t release plugins collection in OmNavigator destructor since it contains a weak reference .

Alexandre Julliard julliard at winehq.org
Tue May 31 13:08:19 CDT 2011


Module: wine
Branch: master
Commit: aa29f5e0f6d10ee8284019b82dedd5683feaeacf
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=aa29f5e0f6d10ee8284019b82dedd5683feaeacf

Author: Jacek Caban <jacek at codeweavers.com>
Date:   Tue May 31 12:19:55 2011 +0200

mshtml: Don't release plugins collection in OmNavigator destructor since it contains a weak reference.

---

 dlls/mshtml/omnavigator.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/dlls/mshtml/omnavigator.c b/dlls/mshtml/omnavigator.c
index 95e8930..611f07d 100644
--- a/dlls/mshtml/omnavigator.c
+++ b/dlls/mshtml/omnavigator.c
@@ -366,10 +366,8 @@ static ULONG WINAPI OmNavigator_Release(IOmNavigator *iface)
     TRACE("(%p) ref=%d\n", This, ref);
 
     if(!ref) {
-        if(This->plugins) {
+        if(This->plugins)
             This->plugins->navigator = NULL;
-            IHTMLPluginsCollection_Release(&This->plugins->IHTMLPluginsCollection_iface);
-        }
         if(This->mime_types)
             This->mime_types->navigator = NULL;
         release_dispex(&This->dispex);




More information about the wine-cvs mailing list