Marcus Meissner : kernel32: Make sure we reference stack data still in scope (Coverity).

Alexandre Julliard julliard at winehq.org
Wed Nov 2 14:23:37 CDT 2011


Module: wine
Branch: master
Commit: df69fa186f193d227a2dc7a200010be30c2b6f71
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=df69fa186f193d227a2dc7a200010be30c2b6f71

Author: Marcus Meissner <marcus at jet.franken.de>
Date:   Wed Nov  2 11:53:40 2011 +0100

kernel32: Make sure we reference stack data still in scope (Coverity).

---

 dlls/kernel32/volume.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/dlls/kernel32/volume.c b/dlls/kernel32/volume.c
index a937f6b..e2b03a2 100644
--- a/dlls/kernel32/volume.c
+++ b/dlls/kernel32/volume.c
@@ -572,6 +572,8 @@ static void VOLUME_GetSuperblockLabel( const UNICODE_STRING *device, HANDLE hand
 static DWORD VOLUME_GetSuperblockSerial( const UNICODE_STRING *device, HANDLE handle,
                                          enum fs_type type, const BYTE *superblock )
 {
+    BYTE block[BLOCK_SIZE];
+
     switch(type)
     {
     case FS_ERROR:
@@ -584,13 +586,9 @@ static DWORD VOLUME_GetSuperblockSerial( const UNICODE_STRING *device, HANDLE ha
         return GETLONG( superblock, 0x33 );
     case FS_UDF:
         {
-            BYTE block[BLOCK_SIZE];
-
             if (!VOLUME_ReadCDBlock(handle, block, 257*BLOCK_SIZE))
                 break;
-
             superblock = block;
-
             /* fallthrough */
         }
     case FS_ISO9660:




More information about the wine-cvs mailing list