Aric Stewart : quartz: Correct a critical section lock reversal issue found by Marcus Meissner ( Coverity).

Alexandre Julliard julliard at winehq.org
Thu Apr 19 13:27:52 CDT 2012


Module: wine
Branch: master
Commit: 6aafd2f1dedfe286e75892bef866d89150c12377
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=6aafd2f1dedfe286e75892bef866d89150c12377

Author: Aric Stewart <aric at codeweavers.com>
Date:   Thu Apr 19 08:11:12 2012 -0500

quartz: Correct a critical section lock reversal issue found by Marcus Meissner (Coverity).

---

 dlls/quartz/videorenderer.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/quartz/videorenderer.c b/dlls/quartz/videorenderer.c
index e1e9628..27c656c 100644
--- a/dlls/quartz/videorenderer.c
+++ b/dlls/quartz/videorenderer.c
@@ -368,11 +368,11 @@ static HRESULT WINAPI VideoRenderer_EndFlush(BaseRenderer* iface)
     if (This->renderer.pMediaSample) {
         ResetEvent(This->hEvent);
         LeaveCriticalSection(iface->pInputPin->pin.pCritSec);
-        LeaveCriticalSection(&iface->filter.csFilter);
         LeaveCriticalSection(&iface->csRenderLock);
+        LeaveCriticalSection(&iface->filter.csFilter);
         WaitForSingleObject(This->hEvent, INFINITE);
-        EnterCriticalSection(&iface->csRenderLock);
         EnterCriticalSection(&iface->filter.csFilter);
+        EnterCriticalSection(&iface->csRenderLock);
         EnterCriticalSection(iface->pInputPin->pin.pCritSec);
     }
     if (This->renderer.filter.state == State_Paused) {




More information about the wine-cvs mailing list