Marcus Meissner : user32: Free the correct dce (Coverity).

Alexandre Julliard julliard at winehq.org
Mon Aug 20 14:16:17 CDT 2012


Module: wine
Branch: master
Commit: 3fb8a4263868d5db0bd2a4d7321b6e1a2af5db23
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=3fb8a4263868d5db0bd2a4d7321b6e1a2af5db23

Author: Marcus Meissner <marcus at jet.franken.de>
Date:   Fri Aug 17 21:23:38 2012 +0200

user32: Free the correct dce (Coverity).

---

 dlls/user32/painting.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/dlls/user32/painting.c b/dlls/user32/painting.c
index 5a3614c..dcf615d 100644
--- a/dlls/user32/painting.c
+++ b/dlls/user32/painting.c
@@ -314,9 +314,11 @@ static struct dce *get_window_dce( HWND hwnd )
 
         if (dce_to_free)
         {
-            SetDCHook( dce->hdc, NULL, 0 );
-            DeleteDC( dce->hdc );
-            HeapFree( GetProcessHeap(), 0, dce );
+            SetDCHook( dce_to_free->hdc, NULL, 0 );
+            DeleteDC( dce_to_free->hdc );
+            HeapFree( GetProcessHeap(), 0, dce_to_free );
+            if (dce_to_free == dce)
+                dce = NULL;
         }
     }
     return dce;




More information about the wine-cvs mailing list