Jacek Caban : mshtml: Added IHTMLStyle::paddingTop implementation.

Alexandre Julliard julliard at winehq.org
Thu Jan 26 14:49:24 CST 2012


Module: wine
Branch: master
Commit: f01571182293bf4f97231119d23f7e8ba45ef811
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=f01571182293bf4f97231119d23f7e8ba45ef811

Author: Jacek Caban <jacek at codeweavers.com>
Date:   Thu Jan 26 14:33:47 2012 +0100

mshtml: Added IHTMLStyle::paddingTop implementation.

---

 dlls/mshtml/htmlstyle.c   |   12 ++++++++----
 dlls/mshtml/tests/style.c |   16 ++++++++++++++++
 2 files changed, 24 insertions(+), 4 deletions(-)

diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c
index 523fc8f..13c00a8 100644
--- a/dlls/mshtml/htmlstyle.c
+++ b/dlls/mshtml/htmlstyle.c
@@ -1556,15 +1556,19 @@ static HRESULT WINAPI HTMLStyle_get_marginLeft(IHTMLStyle *iface, VARIANT *p)
 static HRESULT WINAPI HTMLStyle_put_paddingTop(IHTMLStyle *iface, VARIANT v)
 {
     HTMLStyle *This = impl_from_IHTMLStyle(iface);
-    FIXME("(%p)->(v%d)\n", This, V_VT(&v));
-    return E_NOTIMPL;
+
+    TRACE("(%p)->(v%d)\n", This, V_VT(&v));
+
+    return set_nsstyle_attr_var(This->nsstyle, STYLEID_PADDING_TOP, &v, ATTR_FIX_PX);
 }
 
 static HRESULT WINAPI HTMLStyle_get_paddingTop(IHTMLStyle *iface, VARIANT *p)
 {
     HTMLStyle *This = impl_from_IHTMLStyle(iface);
-    FIXME("(%p)->(%p)\n", This, p);
-    return E_NOTIMPL;
+
+    TRACE("(%p)->(%p)\n", This, p);
+
+    return get_nsstyle_attr_var(This->nsstyle, STYLEID_PADDING_TOP, p, 0);
 }
 
 static HRESULT WINAPI HTMLStyle_put_paddingRight(IHTMLStyle *iface, VARIANT v)
diff --git a/dlls/mshtml/tests/style.c b/dlls/mshtml/tests/style.c
index e950f83..dc7908f 100644
--- a/dlls/mshtml/tests/style.c
+++ b/dlls/mshtml/tests/style.c
@@ -1228,6 +1228,22 @@ static void test_body_style(IHTMLStyle *style)
     ok(!str, "padding = %s\n", wine_dbgstr_w(str));
     SysFreeString(str);
 
+    hres = IHTMLStyle_get_paddingTop(style, &v);
+    ok(hres == S_OK, "get_paddingTop: %08x\n", hres);
+    ok(V_VT(&v) == VT_BSTR, "V_VT(v) = %d\n", V_VT(&v));
+    ok(!V_BSTR(&v), "V_BSTR(v) = %s\n", wine_dbgstr_w(V_BSTR(&v)));
+
+    V_VT(&v) = VT_I4;
+    V_I4(&v) = 6;
+    hres = IHTMLStyle_put_paddingTop(style, v);
+    ok(hres == S_OK, "put_paddingTop failed: %08x\n", hres);
+
+    hres = IHTMLStyle_get_paddingTop(style, &v);
+    ok(hres == S_OK, "get_paddingTop: %08x\n", hres);
+    ok(V_VT(&v) == VT_BSTR, "V_VT(v) = %d\n", V_VT(&v));
+    ok(!strcmp_wa(V_BSTR(&v), "6px"), "V_BSTR(v) = %s\n", wine_dbgstr_w(V_BSTR(&v)));
+    VariantClear(&v);
+
     str = a2bstr("1");
     hres = IHTMLStyle_put_padding(style, str);
     ok(hres == S_OK, "put_padding failed: %08x\n", hres);




More information about the wine-cvs mailing list