Dmitry Timoshkov : windowscodecs: Add a test for invalid predefined palette type.

Alexandre Julliard julliard at winehq.org
Mon Jul 23 13:54:24 CDT 2012


Module: wine
Branch: master
Commit: 9083bcc59c48736641381dd87551c47804be5572
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=9083bcc59c48736641381dd87551c47804be5572

Author: Dmitry Timoshkov <dmitry at baikal.ru>
Date:   Mon Jul 23 12:49:03 2012 +0900

windowscodecs: Add a test for invalid predefined palette type.

---

 dlls/windowscodecs/palette.c       |    4 ++--
 dlls/windowscodecs/tests/palette.c |   10 ++++++++++
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/dlls/windowscodecs/palette.c b/dlls/windowscodecs/palette.c
index 62c7907..096258a 100644
--- a/dlls/windowscodecs/palette.c
+++ b/dlls/windowscodecs/palette.c
@@ -403,8 +403,8 @@ static HRESULT WINAPI PaletteImpl_InitializePredefined(IWICPalette *iface,
         break;
 
     default:
-        FIXME("(%p,%u,%d): stub\n", iface, type, add_transparent);
-        return E_NOTIMPL;
+        WARN("invalid palette type %u\n", type);
+        return E_INVALIDARG;
     }
 
     EnterCriticalSection(&This->lock);
diff --git a/dlls/windowscodecs/tests/palette.c b/dlls/windowscodecs/tests/palette.c
index 5a8c808..499d59d 100644
--- a/dlls/windowscodecs/tests/palette.c
+++ b/dlls/windowscodecs/tests/palette.c
@@ -402,6 +402,16 @@ static void test_predefined_palette(void)
                           &IID_IWICImagingFactory, (void **)&factory);
     ok(hr == S_OK, "CoCreateInstance error %#x\n", hr);
 
+    hr = IWICImagingFactory_CreatePalette(factory, &palette);
+    ok(hr == S_OK, "CreatePalette error %#x\n", hr);
+    hr = IWICPalette_InitializePredefined(palette, WICBitmapPaletteTypeCustom, FALSE);
+    ok(hr == E_INVALIDARG, "expected E_INVALIDARG, got %#x\n", hr);
+    hr = IWICPalette_InitializePredefined(palette, WICBitmapPaletteTypeMedianCut, FALSE);
+    ok(hr == E_INVALIDARG, "expected E_INVALIDARG, got %#x\n", hr);
+    hr = IWICPalette_InitializePredefined(palette, 0x0f, FALSE);
+    ok(hr == E_INVALIDARG, "expected E_INVALIDARG, got %#x\n", hr);
+    IWICPalette_Release(palette);
+
     for (i = 0; i < sizeof(td)/sizeof(td[0]); i++)
     {
         hr = IWICImagingFactory_CreatePalette(factory, &palette);




More information about the wine-cvs mailing list