Jacek Caban : mshtml: Fixed leak in fill_props.

Alexandre Julliard julliard at winehq.org
Wed Nov 21 14:45:15 CST 2012


Module: wine
Branch: master
Commit: 720c0c810d9ef4e3fac3c0a235cdaf5cc7b9172e
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=720c0c810d9ef4e3fac3c0a235cdaf5cc7b9172e

Author: Jacek Caban <jacek at codeweavers.com>
Date:   Wed Nov 21 12:00:48 2012 +0100

mshtml: Fixed leak in fill_props.

---

 dlls/mshtml/propbag.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/dlls/mshtml/propbag.c b/dlls/mshtml/propbag.c
index f7bcf28..716f383 100644
--- a/dlls/mshtml/propbag.c
+++ b/dlls/mshtml/propbag.c
@@ -288,7 +288,7 @@ static HRESULT fill_props(nsIDOMHTMLElement *nselem, PropertyBag *prop_bag)
 
     nsres = nsIDOMNodeList_GetLength(params, &length);
     if(NS_FAILED(nsres))
-        return S_OK;
+        length = 0;
 
     for(i=0; i < length; i++) {
         nsres = nsIDOMNodeList_Item(params, i, &nsnode);
@@ -330,6 +330,7 @@ static HRESULT fill_props(nsIDOMHTMLElement *nselem, PropertyBag *prop_bag)
         }
     }
 
+    nsIDOMNodeList_Release(params);
     return hres;
 }
 




More information about the wine-cvs mailing list