Nikolay Sivov : oledb32: Properly free property sets and propinfo sets ( Coverity).

Alexandre Julliard julliard at winehq.org
Thu Nov 29 14:15:44 CST 2012


Module: wine
Branch: master
Commit: 75cc571fabd101bace788a67c3e3a2cfdadd199b
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=75cc571fabd101bace788a67c3e3a2cfdadd199b

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Thu Nov 29 08:22:55 2012 -0500

oledb32: Properly free property sets and propinfo sets (Coverity).

---

 dlls/oledb32/datainit.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/oledb32/datainit.c b/dlls/oledb32/datainit.c
index b53e08a..a191c88 100644
--- a/dlls/oledb32/datainit.c
+++ b/dlls/oledb32/datainit.c
@@ -355,8 +355,8 @@ static void free_dbpropset(ULONG count, DBPROPSET *propset)
             VariantClear(&propset[i].rgProperties[p].vValue);
             CoTaskMemFree(&propset[i].rgProperties[p]);
         }
-        CoTaskMemFree(&propset[i]);
     }
+    CoTaskMemFree(propset);
 }
 
 static void free_dbpropinfoset(ULONG count, DBPROPINFOSET *propinfoset)
@@ -372,8 +372,8 @@ static void free_dbpropinfoset(ULONG count, DBPROPINFOSET *propinfoset)
             VariantClear(&propinfoset[i].rgPropertyInfos[p].vValues);
             CoTaskMemFree(&propinfoset[i].rgPropertyInfos[p]);
         }
-        CoTaskMemFree(&propinfoset[i]);
     }
+    CoTaskMemFree(propinfoset);
 }
 
 static HRESULT WINAPI datainit_GetInitializationString(IDataInitialize *iface, IUnknown *datasource,




More information about the wine-cvs mailing list