Marcus Meissner : advapi32: Avoid memory leak on pipe read failure ( Coverity).

Alexandre Julliard julliard at winehq.org
Wed Oct 3 13:20:36 CDT 2012


Module: wine
Branch: master
Commit: aaabec2b3376c3012eceb7f9ae247e2b67949e18
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=aaabec2b3376c3012eceb7f9ae247e2b67949e18

Author: Marcus Meissner <marcus at jet.franken.de>
Date:   Wed Oct  3 16:52:05 2012 +0200

advapi32: Avoid memory leak on pipe read failure (Coverity).

---

 dlls/advapi32/service.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/dlls/advapi32/service.c b/dlls/advapi32/service.c
index f69e78f..49d56d1 100644
--- a/dlls/advapi32/service.c
+++ b/dlls/advapi32/service.c
@@ -402,11 +402,13 @@ static DWORD WINAPI service_control_dispatcher(LPVOID arg)
             {
                 if (GetLastError() != ERROR_BROKEN_PIPE)
                     ERR( "pipe read failed error %u\n", GetLastError() );
+                HeapFree( GetProcessHeap(), 0, data );
                 break;
             }
             if (count != data_size)
             {
                 ERR( "partial pipe read %u/%u\n", count, data_size );
+                HeapFree( GetProcessHeap(), 0, data );
                 break;
             }
         }




More information about the wine-cvs mailing list