Charles Davis : urlmon: Fix potential use of uninitialized variable (Clang) .

Alexandre Julliard julliard at winehq.org
Tue Sep 18 14:04:28 CDT 2012


Module: wine
Branch: master
Commit: 7c83bd84fd95620cbd29d745c90809927d7760fb
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=7c83bd84fd95620cbd29d745c90809927d7760fb

Author: Charles Davis <cdavis5x at gmail.com>
Date:   Mon Sep 17 23:49:50 2012 -0600

urlmon: Fix potential use of uninitialized variable (Clang).

---

 dlls/urlmon/http.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/dlls/urlmon/http.c b/dlls/urlmon/http.c
index 18a99ae..b2c3d10 100644
--- a/dlls/urlmon/http.c
+++ b/dlls/urlmon/http.c
@@ -215,10 +215,9 @@ static HRESULT handle_http_error(HttpProtocol *This, DWORD error)
 
             hres = IWindowForBindingUI_GetWindow(wfb_ui, iid_reason, &hwnd);
             IWindowForBindingUI_Release(wfb_ui);
-            if(FAILED(hres))
-                hwnd = NULL;
         }
 
+        if(FAILED(hres)) hwnd = NULL;
 
         dlg_flags = FLAGS_ERROR_UI_FLAGS_CHANGE_OPTIONS | FLAGS_ERROR_UI_FLAGS_GENERATE_DATA;
         if(This->base.bindf & BINDF_NO_UI)




More information about the wine-cvs mailing list