=?UTF-8?Q?Rico=20Sch=C3=BCller=20?=: d3dx9: Avoid variable assignment in D3DXQuaternionNormalize().

Alexandre Julliard julliard at winehq.org
Wed Sep 26 14:06:50 CDT 2012


Module: wine
Branch: master
Commit: 5accb12c1298a81a59e7d19080543ebf75635aed
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=5accb12c1298a81a59e7d19080543ebf75635aed

Author: Rico Schüller <kgbricola at web.de>
Date:   Wed Sep 26 13:57:21 2012 +0200

d3dx9: Avoid variable assignment in D3DXQuaternionNormalize().

---

 dlls/d3dx9_36/math.c |   19 ++++++++-----------
 1 files changed, 8 insertions(+), 11 deletions(-)

diff --git a/dlls/d3dx9_36/math.c b/dlls/d3dx9_36/math.c
index c6fa19a..9be3011 100644
--- a/dlls/d3dx9_36/math.c
+++ b/dlls/d3dx9_36/math.c
@@ -1338,23 +1338,20 @@ D3DXQUATERNION* WINAPI D3DXQuaternionMultiply(D3DXQUATERNION *pout, CONST D3DXQU
     return pout;
 }
 
-D3DXQUATERNION* WINAPI D3DXQuaternionNormalize(D3DXQUATERNION *pout, CONST D3DXQUATERNION *pq)
+D3DXQUATERNION * WINAPI D3DXQuaternionNormalize(D3DXQUATERNION *out, const D3DXQUATERNION *q)
 {
-    D3DXQUATERNION out;
     FLOAT norm;
 
-    TRACE("(%p, %p)\n", pout, pq);
-
-    norm = D3DXQuaternionLength(pq);
+    TRACE("out %p, q %p\n", out, q);
 
-    out.x = pq->x / norm;
-    out.y = pq->y / norm;
-    out.z = pq->z / norm;
-    out.w = pq->w / norm;
+    norm = D3DXQuaternionLength(q);
 
-    *pout=out;
+    out->x = q->x / norm;
+    out->y = q->y / norm;
+    out->z = q->z / norm;
+    out->w = q->w / norm;
 
-    return pout;
+    return out;
 }
 
 D3DXQUATERNION * WINAPI D3DXQuaternionRotationAxis(D3DXQUATERNION *out, const D3DXVECTOR3 *v, FLOAT angle)




More information about the wine-cvs mailing list