Francois Gouget : testbot: Always log the 'errno' with an error.

Alexandre Julliard julliard at winehq.org
Wed Apr 24 13:23:55 CDT 2013


Module: tools
Branch: master
Commit: c1907e42fda5598142decf23e9c49ad53f526b94
URL:    http://source.winehq.org/git/tools.git/?a=commit;h=c1907e42fda5598142decf23e9c49ad53f526b94

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Wed Apr 24 18:38:12 2013 +0200

testbot: Always log the 'errno' with an error.

Also log the relevant filename if any.

---

 testbot/bin/WineSendLog.pl       |    2 +-
 testbot/lib/WineTestBot/Log.pm   |    2 +-
 testbot/lib/WineTestBot/Tasks.pm |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/testbot/bin/WineSendLog.pl b/testbot/bin/WineSendLog.pl
index 8ea4d9c..87be910 100755
--- a/testbot/bin/WineSendLog.pl
+++ b/testbot/bin/WineSendLog.pl
@@ -131,7 +131,7 @@ sub ReadLog
   }
   else
   {
-    LogMsg "Unable to open log $LogName\n";
+    LogMsg "Unable to open '$LogName' for reading: $!\n";
   }
 
   return \@Messages;
diff --git a/testbot/lib/WineTestBot/Log.pm b/testbot/lib/WineTestBot/Log.pm
index 6982943..b88ba6f 100644
--- a/testbot/lib/WineTestBot/Log.pm
+++ b/testbot/lib/WineTestBot/Log.pm
@@ -70,7 +70,7 @@ sub SetupRedirects()
     }
     else
     {
-      LogMsg "unable to redirect stderr to the log file\n";
+      LogMsg "unable to redirect stderr to '$logfile': $!\n";
     }
   }
 }
diff --git a/testbot/lib/WineTestBot/Tasks.pm b/testbot/lib/WineTestBot/Tasks.pm
index c892066..210815d 100644
--- a/testbot/lib/WineTestBot/Tasks.pm
+++ b/testbot/lib/WineTestBot/Tasks.pm
@@ -119,7 +119,7 @@ sub Run
     }
     else
     {
-      LogMsg "unable to redirect stderr to '$TaskDir/err'\n";
+      LogMsg "unable to redirect stderr to '$TaskDir/err': $!\n";
     }
     $ENV{PATH} = "/usr/bin:/bin";
     delete $ENV{ENV};




More information about the wine-cvs mailing list