Francois Gouget : testbot/TestAgent: Fix create_ip_socket().

Alexandre Julliard julliard at winehq.org
Tue Dec 17 10:10:03 CST 2013


Module: tools
Branch: master
Commit: 25149bf382b7fae85d4a6ce46b78481bdd14dc6c
URL:    http://source.winehq.org/git/tools.git/?a=commit;h=25149bf382b7fae85d4a6ce46b78481bdd14dc6c

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Tue Dec 17 11:01:24 2013 +0100

testbot/TestAgent: Fix create_ip_socket().

It's not supposed to mask exceptions as that prevents the detection of connection timeouts.

---

 testbot/lib/WineTestBot/TestAgent.pm |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/testbot/lib/WineTestBot/TestAgent.pm b/testbot/lib/WineTestBot/TestAgent.pm
index f542991..dfc86e3 100644
--- a/testbot/lib/WineTestBot/TestAgent.pm
+++ b/testbot/lib/WineTestBot/TestAgent.pm
@@ -790,9 +790,7 @@ sub _SendFile($$$)
 
 sub create_ip_socket(@)
 {
-  my $socket;
-  eval { $socket = IO::Socket::IP->new(@_); };
-  return $socket;
+  return IO::Socket::IP->new(@_);
 }
 
 sub create_inet_socket(@)




More information about the wine-cvs mailing list