Jacek Caban : mshtml: Don' t crash if fire_event_obj is called on detached document.

Alexandre Julliard julliard at winehq.org
Tue Feb 19 13:33:04 CST 2013


Module: wine
Branch: master
Commit: 5069ad71b4ce3a0bf8b084842672573837e1a88a
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=5069ad71b4ce3a0bf8b084842672573837e1a88a

Author: Jacek Caban <jacek at codeweavers.com>
Date:   Tue Feb 19 17:05:11 2013 +0100

mshtml: Don't crash if fire_event_obj is called on detached document.

---

 dlls/mshtml/htmlevent.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/dlls/mshtml/htmlevent.c b/dlls/mshtml/htmlevent.c
index ea0201f..97f9ea9 100644
--- a/dlls/mshtml/htmlevent.c
+++ b/dlls/mshtml/htmlevent.c
@@ -1057,9 +1057,14 @@ static void fire_event_obj(HTMLDocumentNode *doc, eventid_t eid, HTMLEventObj *e
 
     TRACE("(%p) %s\n", doc, debugstr_w(event_info[eid].name));
 
+    window = doc->window;
+    if(!window) {
+        WARN("NULL window\n");
+        return;
+    }
+
     htmldoc_addref(&doc->basedoc);
 
-    window = doc->window;
     prev_event = window->event;
     window->event = event_obj ? &event_obj->IHTMLEventObj_iface : NULL;
 




More information about the wine-cvs mailing list