Andrew Talbot : d3drm: Avoid signed-unsigned integer comparisons.

Alexandre Julliard julliard at winehq.org
Thu Jan 3 13:31:12 CST 2013


Module: wine
Branch: master
Commit: c39f7e7fdb2d731a8b0f838aed7f544fef08c29d
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=c39f7e7fdb2d731a8b0f838aed7f544fef08c29d

Author: Andrew Talbot <andrew.talbot at talbotville.com>
Date:   Wed Jan  2 21:49:12 2013 +0000

d3drm: Avoid signed-unsigned integer comparisons.

---

 dlls/d3drm/meshbuilder.c |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/dlls/d3drm/meshbuilder.c b/dlls/d3drm/meshbuilder.c
index 4fc8462..a07ce54 100644
--- a/dlls/d3drm/meshbuilder.c
+++ b/dlls/d3drm/meshbuilder.c
@@ -325,7 +325,7 @@ static inline IDirect3DRMMeshBuilderImpl *impl_from_IDirect3DRMMeshBuilder3(IDir
 
 static void clean_mesh_builder_data(IDirect3DRMMeshBuilderImpl *mesh_builder)
 {
-    int i;
+    DWORD i;
 
     HeapFree(GetProcessHeap(), 0, mesh_builder->name);
     mesh_builder->name = NULL;
@@ -1689,7 +1689,7 @@ static HRESULT WINAPI IDirect3DRMMeshBuilder3Impl_Scale(IDirect3DRMMeshBuilder3*
                                                         D3DVALUE sx, D3DVALUE sy, D3DVALUE sz)
 {
     IDirect3DRMMeshBuilderImpl *This = impl_from_IDirect3DRMMeshBuilder3(iface);
-    int i;
+    DWORD i;
 
     TRACE("(%p)->(%f,%f,%f)\n", This, sx, sy, sz);
 
@@ -2108,7 +2108,8 @@ static HRESULT WINAPI IDirect3DRMMeshBuilder3Impl_CreateMesh(IDirect3DRMMeshBuil
     /* If there is mesh data, create a group and put data inside */
     if (This->nb_vertices)
     {
-        int i, j, k;
+        DWORD i, j;
+        int k;
         D3DRMVERTEX* vertices;
 
         vertices = HeapAlloc(GetProcessHeap(), 0, This->nb_vertices * sizeof(D3DRMVERTEX));
@@ -2588,7 +2589,7 @@ static ULONG WINAPI IDirect3DRMMeshImpl_Release(IDirect3DRMMesh* iface)
 
     if (!ref)
     {
-        int i;
+        DWORD i;
 
         for (i = 0; i < This->nb_groups; i++)
         {
@@ -2776,7 +2777,7 @@ static HRESULT WINAPI IDirect3DRMMeshImpl_AddGroup(IDirect3DRMMesh* iface,
     }
     else
     {
-        int i;
+        unsigned i;
         unsigned nb_indices;
         unsigned* face_data_ptr = face_data;
         group->face_data_size = 0;




More information about the wine-cvs mailing list